Create ElementAnnotation objects prior to resolution.

Create ElementAnnotation objects prior to resolution.

This is a prerequisite to fixing #25285
(ConstantEvaluationTarget_Annotation consumes too much memory,
shouldn't exist).  By creating the ElementAnnotation objects early, we
will be able to refer to them from the ConstantFinder; this will allow
us to use the ElementAnnotation objects as constant evaluation
targets.

Note: there is a small semantic change.  Previously, Element.metadata
only contained ElementAnnotation objects for annotations that were
successfully resolved.  Now, it contains ElementAnnotation objects for
all annotations.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3977c9f2274df35df6332a65af9973fd6517bc12

[Paul Berry, 2016-02-02 22:19:33]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-02 22:37:47]

LGTM

[Paul Berry, 2016-02-02 22:43:07]

Description was changed from

==========
Create ElementAnnotation objects prior to resolution.

This is a prerequisite to fixing #25285
(ConstantEvaluationTarget_Annotation consumes too much memory,
shouldn't exist).  By creating the ElementAnnotation objects early, we
will be able to refer to them from the ConstantFinder; this will allow
us to use the ElementAnnotation objects as constant evaluation
targets.

Note: there is a small semantic change.  Previously, Element.metadata
only contained ElementAnnotation objects for annotations that were
successfully resolved.  Now, it contains ElementAnnotation objects for
all annotations.
==========

to

==========
Create ElementAnnotation objects prior to resolution.

This is a prerequisite to fixing #25285
(ConstantEvaluationTarget_Annotation consumes too much memory,
shouldn't exist).  By creating the ElementAnnotation objects early, we
will be able to refer to them from the ConstantFinder; this will allow
us to use the ElementAnnotation objects as constant evaluation
targets.

Note: there is a small semantic change.  Previously, Element.metadata
only contained ElementAnnotation objects for annotations that were
successfully resolved.  Now, it contains ElementAnnotation objects for
all annotations.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3977c9f2274df35df6332a65af9973fd6517bc12
==========

[Paul Berry, 2016-02-02 22:43:08]

Committed patchset #2 (id:20001) manually as
3977c9f2274df35df6332a65af9973fd6517bc12 (presubmit successful).