Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1668473002: ServiceWorker: Wait for the completion of async tasks on ExtendableMessageEvent (Closed)

Created:
4 years, 10 months ago by nhiroki
Modified:
4 years, 10 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Wait for the completion of async tasks on ExtendableMessageEvent ExtendableMessageEvent should wait for the completion of async tasks so that it can prevent a service worker from being killed while the tasks are running. Depends on https://codereview.chromium.org/1658073002/ BUG=570820 Committed: https://crrev.com/8bc72b565a122bc861597a244a3b251cf1be5f58 Cr-Commit-Position: refs/heads/master@{#375153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/unregister-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sandboxed-iframe-fetch-event-worker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/claim-worker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/client-id-worker.js View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/clients-matchall-worker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/indexeddb-worker.js View 1 chunk +19 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-to-client-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nhiroki
PTAL, thanks!
4 years, 10 months ago (2016-02-03 06:52:52 UTC) #3
horo
lgtm
4 years, 10 months ago (2016-02-04 06:28:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668473002/1
4 years, 10 months ago (2016-02-12 07:32:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 10:11:26 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bc72b565a122bc861597a244a3b251cf1be5f58
Cr-Commit-Position: refs/heads/master@{#375153}

Powered by Google App Engine
This is Rietveld 408576698