third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js - Issue 1668473002: ServiceWorker: Wait for the completion of async tasks on ExtendableMessageEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

Issue 1668473002: ServiceWorker: Wait for the completion of async tasks on ExtendableMessageEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sandboxed-iframe-fetch-event-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

index caf3d8a6ad61d84300160b7801a7e8f07e9f99ae..5ea64609b0a9f8b44848cf837309cf263b63112e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

@@ -81,11 +81,11 @@ var TESTS = [

self.onmessage = function(e) {

if (e.data == 'start') {

- initialize().then(runNextTestOrQuit);

+ e.waitUntil(initialize().then(runNextTestOrQuit));

} else {

- initialize().then(function() {

+ e.waitUntil(initialize().then(function() {

self.postMessage('received unexpected message');

self.postMessage('quit');

- });

+ }));

}

};