media/audio/mac/audio_low_latency_input_mac_unittest.cc - Issue 1668373003: Improved error handling in AUAudioInputStream::Open() for Mac OSX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/mac/audio_low_latency_input_mac_unittest.cc

Issue 1668373003: Improved error handling in AUAudioInputStream::Open() for Mac OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed audio input unit test. Now inline with how output side works as well Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/mac/audio_low_latency_input_mac_unittest.cc

diff --git a/media/audio/mac/audio_low_latency_input_mac_unittest.cc b/media/audio/mac/audio_low_latency_input_mac_unittest.cc

index 081bc8d9e9abea53aa4d54db32bcda18739895aa..a12fbaf099fa6f3480f2e649d5c27286a2d39090 100644

--- a/media/audio/mac/audio_low_latency_input_mac_unittest.cc

+++ b/media/audio/mac/audio_low_latency_input_mac_unittest.cc

@@ -191,9 +191,7 @@ TEST_F(MacAudioInputTest, AUAudioInputStreamMiscCallingSequences) {

AudioInputStream* ais = CreateDefaultAudioInputStream();

AUAudioInputStream* auais = static_cast<AUAudioInputStream*>(ais);

- // Open(), Open() should fail the second time.

EXPECT_TRUE(ais->Open());

- EXPECT_FALSE(ais->Open());

henrika (OOO until Aug 14) 2016/02/05 13:58:05 We don't support this case on the output side or a

tommi (sloooow) - chröme 2016/02/05 14:06:51 Agree.

MockAudioInputCallback sink;

« no previous file with comments | « media/audio/mac/audio_low_latency_input_mac.cc ('k') | no next file » | no next file with comments »