Improved error handling in AUAudioInputStream::Open() for Mac OSX

media/audio/mac/audio_low_latency_input_mac_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/environment.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
@@ skipping 173 matching lines @@
   ais->Stop();
   ais->Close();
 }
 
 // Test some additional calling sequences.
 TEST_F(MacAudioInputTest, AUAudioInputStreamMiscCallingSequences) {
   ABORT_AUDIO_TEST_IF_NOT(InputDevicesAvailable());
   AudioInputStream* ais = CreateDefaultAudioInputStream();
   AUAudioInputStream* auais = static_cast<AUAudioInputStream*>(ais);
 
-  // Open(), Open() should fail the second time.
   EXPECT_TRUE(ais->Open());
-  EXPECT_FALSE(ais->Open());

[henrika (OOO until Aug 14), 2016/02/05 13:58:05]

We don't support this case on the output side or any other platform either.
Removing this test since we now fail (on DCHECK) if Open() is called twice in a
row without intermediate Close(). 

[tommi (sloooow) - chröme, 2016/02/05 14:06:51]

Agree.

 
   MockAudioInputCallback sink;
 
   // Start(), Start() is a valid calling sequence (second call does nothing).
   ais->Start(&sink);
   EXPECT_TRUE(auais->IsRunning());
   ais->Start(&sink);
   EXPECT_TRUE(auais->IsRunning());
 
   // Stop(), Stop() is a valid calling sequence (second call does nothing).
@@ skipping 83 matching lines @@
   WriteToFileAudioSink file_sink(file_name);
   fprintf(stderr, "               >> Speak into the mic while recording...\n");
   ais->Start(&file_sink);
   base::PlatformThread::Sleep(TestTimeouts::action_timeout());
   ais->Stop();
   fprintf(stderr, "               >> Recording has stopped.\n");
   ais->Close();
 }
 
 }  // namespace media