Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166823002: Fix DCHECK failure in RenderWidgetHostViewAura::InsertText() (Closed)

Created:
6 years, 10 months ago by babu
Modified:
6 years, 10 months ago
Reviewers:
Yuki
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix DCHECK failure in RenderWidgetHostViewAura::InsertText() Do not call InsertText() if there is no focused text input client or the text input type is TEXT_INPUT_TYPE_NONE. BUG=343875 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252049

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ui/base/ime/input_method_auralinux.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
babu
Yuki, could you please review this?
6 years, 10 months ago (2014-02-18 23:27:26 UTC) #1
Yuki
lgtm https://codereview.chromium.org/166823002/diff/1/ui/base/ime/input_method_auralinux.cc File ui/base/ime/input_method_auralinux.cc (right): https://codereview.chromium.org/166823002/diff/1/ui/base/ime/input_method_auralinux.cc#newcode155 ui/base/ime/input_method_auralinux.cc:155: if (!IsTextInputTypeNone()) nit: if (!IsTextInputTypeNone()) GetTextInputClient()->InsertText(text); seems now ...
6 years, 10 months ago (2014-02-19 02:29:58 UTC) #2
babu
On 2014/02/19 02:29:58, Yuki wrote: > nit: > if (!IsTextInputTypeNone()) > GetTextInputClient()->InsertText(text); > seems now ...
6 years, 10 months ago (2014-02-19 07:20:57 UTC) #3
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-19 07:25:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/166823002/100001
6 years, 10 months ago (2014-02-19 07:25:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 08:33:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=266240
6 years, 10 months ago (2014-02-19 08:33:34 UTC) #7
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-19 09:03:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/166823002/100001
6 years, 10 months ago (2014-02-19 09:03:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/166823002/100001
6 years, 10 months ago (2014-02-19 14:55:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/166823002/100001
6 years, 10 months ago (2014-02-19 15:27:42 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:44:46 UTC) #12
Message was sent while issue was closed. 
Change committed as 252049

Powered by Google App Engine
This is Rietveld 408576698