ui/base/ime/input_method_auralinux.cc - Issue 166823002: Fix DCHECK failure in RenderWidgetHostViewAura::InsertText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_auralinux.cc

Issue 166823002: Fix DCHECK failure in RenderWidgetHostViewAura::InsertText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ime/input_method_auralinux.cc

diff --git a/ui/base/ime/input_method_auralinux.cc b/ui/base/ime/input_method_auralinux.cc

index 2ec945dca37aa92a4173d4eb37dec5a23202522a..c31576d5efcbe6559427fbf91c44e632e6819093 100644

--- a/ui/base/ime/input_method_auralinux.cc

+++ b/ui/base/ime/input_method_auralinux.cc

@@ -151,9 +151,8 @@ bool InputMethodAuraLinux::IsCandidatePopupOpen() const {

// Overriden from ui::LinuxInputMethodContextDelegate

void InputMethodAuraLinux::OnCommit(const base::string16& text) {

- TextInputClient* text_input_client = GetTextInputClient();

- if (text_input_client)

- text_input_client->InsertText(text);

+ if (!IsTextInputTypeNone())

+ GetTextInputClient()->InsertText(text);

}

void InputMethodAuraLinux::OnPreeditChanged(

« no previous file with comments | « no previous file | no next file » | no next file with comments »