Issue 16682004: Follow up patch for document.currentScript

Issue 16682004: Follow up patch for document.currentScript (Closed)

Created:
7 years, 6 months ago by arv (Not doing code reviews)

Modified:
7 years, 6 months ago

Reviewers:
esprehn, abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Follow up patch for document.currentScript This is a clean up patch based on the code reviews comments after the patch was committed. https://chromiumcodereview.appspot.com/14852011/ BUG=240876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152237

Patch Set 2 : Move things around a bit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
M	Source/core/dom/ScriptElement.cpp	View	1	3 chunks	+10 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLScriptElement.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGScriptElement.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGScriptElement.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Thanks for following up. One minor comment below. https://codereview.chromium.org/16682004/diff/1/Source/core/dom/ScriptElement.cpp File Source/core/dom/ScriptElement.cpp (right): https://codereview.chromium.org/16682004/diff/1/Source/core/dom/ScriptElement.cpp#newcode292 Source/core/dom/ScriptElement.cpp:292: } ...

7 years, 6 months ago (2013-06-11 18:18:23 UTC) #2

arv (Not doing code reviews)

https://codereview.chromium.org/16682004/diff/1/Source/core/dom/ScriptElement.cpp File Source/core/dom/ScriptElement.cpp (right): https://codereview.chromium.org/16682004/diff/1/Source/core/dom/ScriptElement.cpp#newcode292 Source/core/dom/ScriptElement.cpp:292: } On 2013/06/11 18:18:23, abarth wrote: > We usually ...

7 years, 6 months ago (2013-06-11 18:44:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/16682004/6001

7 years, 6 months ago (2013-06-11 18:53:06 UTC) #5

Message was sent while issue was closed.

Change committed as 152237

Expand Messages | Collapse Messages