Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1668183002: Remove the SVG parsing "generic error" reporting special case (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the SVG parsing "generic error" reporting special case With most error-reporting sites switched to using non-generic errors, the workaround for the generic error message can be removed - giving all messages a similar structure ("<context>: <message>"). BUG=231612 Committed: https://crrev.com/05ac0071b01f648d9af6368969ef5c2e655b9f41 Cr-Commit-Position: refs/heads/master@{#373941}

Patch Set 1 #

Patch Set 2 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 2 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fs
The last one of these (for now at least) - only animation stuff left, and ...
4 years, 10 months ago (2016-02-05 21:39:43 UTC) #4
pdr.
On 2016/02/05 at 21:39:43, fs wrote: > The last one of these (for now at ...
4 years, 10 months ago (2016-02-05 21:41:49 UTC) #5
fs
On 2016/02/05 at 21:41:49, pdr wrote: > On 2016/02/05 at 21:39:43, fs wrote: > > ...
4 years, 10 months ago (2016-02-05 21:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1668183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1668183002/20001
4 years, 10 months ago (2016-02-05 21:55:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 23:13:16 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 23:13:59 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05ac0071b01f648d9af6368969ef5c2e655b9f41
Cr-Commit-Position: refs/heads/master@{#373941}

Powered by Google App Engine
This is Rietveld 408576698