Remove the SVG parsing "generic error" reporting special case

third_party/WebKit/Source/core/svg/SVGParsingError.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/svg/SVGParsingError.h"
 
 #include "core/dom/QualifiedName.h"
 #include "platform/JSONValues.h"
 #include "wtf/text/CharacterNames.h"
 #include "wtf/text/StringBuilder.h"
@@ skipping 37 matching lines @@
         return std::make_pair("Expected path command, ", ".");
     case SVGParseStatus::ExpectedStartOfArguments:
         return std::make_pair("Expected '(', ", ".");
     case SVGParseStatus::ExpectedTransformFunction:
         return std::make_pair("Expected transform function, ", ".");
     case SVGParseStatus::NegativeValue:
         return std::make_pair("A negative value is not valid. (", ")");
     case SVGParseStatus::ZeroValue:
         return std::make_pair("A value of zero is not valid. (", ")");
     case SVGParseStatus::ParsingFailed:
+        return std::make_pair("Invalid value, ", ".");
     default:
         ASSERT_NOT_REACHED();
         break;
     }
     return std::make_pair("", "");
 }
 
 bool disableLocus(SVGParseStatus status)
 {
     // Disable locus for semantic errors and generic errors (see TODO below).
@@ skipping 27 matching lines @@
     }
     builder.append('"');
 }
 
 } // namespace
 
 String SVGParsingError::format(const String& tagName, const QualifiedName& name, const AtomicString& value) const
 {
     StringBuilder builder;
 
-    // TODO(fs): Remove this case once enough specific errors have been added.
-    if (status() == SVGParseStatus::ParsingFailed) {
-        builder.appendLiteral("Invalid value for ");
-        appendErrorContextInfo(builder, tagName, name);
-        builder.append('=');
-        appendValue(builder, *this, value);
-    } else {
-        appendErrorContextInfo(builder, tagName, name);
-        builder.appendLiteral(": ");
+    appendErrorContextInfo(builder, tagName, name);
+    builder.appendLiteral(": ");
 
-        if (hasLocus() && locus() == value.length())
-            builder.appendLiteral("Unexpected end of attribute. ");
+    if (hasLocus() && locus() == value.length())
+        builder.appendLiteral("Unexpected end of attribute. ");
 
-        auto message = messageForStatus(status());
-        builder.append(message.first);
-        appendValue(builder, *this, value);
-        builder.append(message.second);
-    }
+    auto message = messageForStatus(status());
+    builder.append(message.first);
+    appendValue(builder, *this, value);
+    builder.append(message.second);
     return builder.toString();
 }
 
 } // namespace blink