third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp ('k') | third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

index b35376b3084ba5a049a890d233c24614d86ab8b6..8eb344d9c3039b6a39fd6dea90fbf06a0c97a973 100644

--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

@@ -28,7 +28,6 @@

#include "core/dom/ParserContentPolicy.h"

#include "core/dom/ScriptableDocumentParser.h"

#include "core/fetch/ResourceClient.h"

-#include "core/fetch/ResourcePtr.h"

#include "core/fetch/ScriptResource.h"

#include "core/xml/parser/XMLErrors.h"

#include "platform/heap/Handle.h"

@@ -185,7 +184,7 @@ private:

XMLErrors m_xmlErrors;

- ResourcePtr<ScriptResource> m_pendingScript;

+ RefPtrWillBeMember<ScriptResource> m_pendingScript;

RefPtrWillBeMember<Element> m_scriptElement;

TextPosition m_scriptStartPosition;