third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/XSLImportRule.cpp ('k') | third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

diff --git a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

index c973b57cceaa18214d3cf27650050f2af9c6f167..62f3115cb0b1ca37b98669df6ef8ee1ea3490d12 100644

--- a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

+++ b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

@@ -103,7 +103,7 @@ static xmlDocPtr docLoaderFunc(

ResourceLoaderOptions fetchOptions(ResourceFetcher::defaultResourceOptions());

FetchRequest request(ResourceRequest(url), FetchInitiatorTypeNames::xml, fetchOptions);

request.setOriginRestriction(FetchRequest::RestrictToSameOrigin);

- ResourcePtr<Resource> resource = RawResource::fetchSynchronously(request, globalResourceFetcher);

+ RefPtrWillBeRawPtr<Resource> resource = RawResource::fetchSynchronously(request, globalResourceFetcher);

if (!resource || !globalProcessor)

return nullptr;