Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: third_party/WebKit/Source/core/svg/SVGUseElement.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGUseElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.h b/third_party/WebKit/Source/core/svg/SVGUseElement.h
index cb7702fbd3910992cb6726b4f0f812cac2ba2e51..0dacc192fd10cf475624e641d193c25ebf9af813 100644
--- a/third_party/WebKit/Source/core/svg/SVGUseElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.h
@@ -39,6 +39,7 @@ class SVGUseElement final : public SVGGraphicsElement,
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SVGUseElement);
+ WILL_BE_USING_PRE_FINALIZER(SVGUseElement, dispose);
public:
static PassRefPtrWillBeRawPtr<SVGUseElement> create(Document&);
~SVGUseElement() override;
@@ -64,6 +65,8 @@ public:
private:
explicit SVGUseElement(Document&);
+ void dispose();
+
FloatRect getBBox() override;
bool isPresentationAttribute(const QualifiedName&) const override;
@@ -104,7 +107,7 @@ private:
void notifyFinished(Resource*) override;
String debugName() const override { return "SVGUseElement"; }
TreeScope* referencedScope() const;
- void setDocumentResource(ResourcePtr<DocumentResource>);
+ void setDocumentResource(PassRefPtrWillBeRawPtr<DocumentResource>);
RefPtrWillBeMember<SVGAnimatedLength> m_x;
RefPtrWillBeMember<SVGAnimatedLength> m_y;
@@ -114,7 +117,7 @@ private:
bool m_haveFiredLoadEvent;
bool m_needsShadowTreeRecreation;
RefPtrWillBeMember<SVGElement> m_targetElementInstance;
- ResourcePtr<DocumentResource> m_resource;
+ RefPtrWillBeMember<DocumentResource> m_resource;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698