Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
index 79a884b17d4d258886efd6adc56e3c3d55b26bc7..8c33782422a948dc04babb1e9b5aae78e009227f 100644
--- a/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
@@ -46,7 +46,7 @@ SVGFEImageElement::~SVGFEImageElement()
#if ENABLE(OILPAN)
if (m_cachedImage) {
m_cachedImage->removeClient(this);
- m_cachedImage = 0;
+ m_cachedImage = nullptr;
}
#else
clearResourceReferences();
@@ -56,6 +56,7 @@ SVGFEImageElement::~SVGFEImageElement()
DEFINE_TRACE(SVGFEImageElement)
{
visitor->trace(m_preserveAspectRatio);
+ visitor->trace(m_cachedImage);
SVGFilterPrimitiveStandardAttributes::trace(visitor);
SVGURIReference::trace(visitor);
}
@@ -72,7 +73,7 @@ void SVGFEImageElement::clearResourceReferences()
{
if (m_cachedImage) {
m_cachedImage->removeClient(this);
- m_cachedImage = 0;
+ m_cachedImage = nullptr;
}
removeAllOutgoingReferences();
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEImageElement.h ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698