third_party/WebKit/Source/core/style/StyleFetchedImageSet.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImage.cpp ('k') | third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

diff --git a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

index 640aea5e5f415717766b17b543bafd545d2a196b..a11d0013f0acbfa0346854722d1183fe11a597a8 100644

--- a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

+++ b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

@@ -27,7 +27,6 @@

#define StyleFetchedImageSet_h

#include "core/fetch/ImageResourceClient.h"

-#include "core/fetch/ResourcePtr.h"

#include "core/style/StyleImage.h"

#include "platform/geometry/LayoutSize.h"

@@ -83,7 +82,7 @@ private:

String debugName() const override { return "StyleFetchedImageSet"; }

- ResourcePtr<ImageResource> m_bestFitImage;

+ RefPtrWillBeMember<ImageResource> m_bestFitImage;

float m_imageScaleFactor;

RawPtrWillBeMember<CSSImageSetValue> m_imageSetValue; // Not retained; it owns us.