third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImageSet.h ('k') | third_party/WebKit/Source/core/svg/SVGFEImageElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

index bab09b1cf7c5a4fd409f6fc7f555be655c01de80..c02f13b3d710961167cd7a00447ef2134391cca5 100644

--- a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

+++ b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

@@ -55,6 +55,7 @@ StyleFetchedImageSet::~StyleFetchedImageSet()

void StyleFetchedImageSet::dispose()

{

m_bestFitImage->removeClient(this);

+ m_bestFitImage = nullptr;

}

WrappedImagePtr StyleFetchedImageSet::data() const

@@ -140,6 +141,7 @@ bool StyleFetchedImageSet::knownToBeOpaque(const LayoutObject* layoutObject) con

DEFINE_TRACE(StyleFetchedImageSet)

{

+ visitor->trace(m_bestFitImage);

visitor->trace(m_imageSetValue);

StyleImage::trace(visitor);

}