Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1667813002: Allow cssTextCache to be used on the main thread only. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
haraken, kinuko, Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow cssTextCache to be used on the main thread only. https://codereview.chromium.org/864143006 tentatively made this singleton cross-thread usable. (Repeated) testing doesn't indicate that it is used outside the main thread, hence switch back to using DEFINE_STATIC_LOCAL(). R=haraken,timloh BUG=549732 Committed: https://crrev.com/90f599d0866263d007607428911e527598dbd585 Cr-Commit-Position: refs/heads/master@{#373493}

Patch Set 1 #

Patch Set 2 : add back release assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 2 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-04 09:15:52 UTC) #3
haraken
LGTM but let's wait for Tim's approval.
4 years, 10 months ago (2016-02-04 09:23:54 UTC) #4
Timothy Loh
lgtm
4 years, 10 months ago (2016-02-04 09:27:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667813002/20001
4 years, 10 months ago (2016-02-04 09:38:00 UTC) #8
kinuko
lgtm.
4 years, 10 months ago (2016-02-04 09:41:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 09:47:17 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 09:48:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90f599d0866263d007607428911e527598dbd585
Cr-Commit-Position: refs/heads/master@{#373493}

Powered by Google App Engine
This is Rietveld 408576698