Remove unsafe DEFINE_STATIC_LOCALs in CSSPrimitiveValue

Remove unsafe DEFINE_STATIC_LOCALs in CSSPrimitiveValue

It looks CSSPrimitiveValue is used both on the main thread and on
the HTMLParser thread.

BUG=367982
TEST=fast/dom with http://crrev.com/874203002

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189163

[kinuko, 2015-01-27 14:19:43]

kinuko@chromium.org changed reviewers:
+ eseidel@chromium.org, timloh@chromium.org

[kinuko, 2015-01-27 14:24:42]

I haven't looked really deeply but it looks it's unsafe usage. Could either of
you take a look?

[kinuko, 2015-01-29 02:55:11]

Patchset #2 (id:20001) has been deleted

[kinuko, 2015-01-29 04:44:30]

kinuko@chromium.org changed reviewers:
+ kouhei@chromium.org

[kinuko, 2015-01-29 04:45:30]

kouhei-san, probably you can review this?

[Timothy Loh, 2015-01-29 04:48:32]

On 2015/01/27 14:24:42, kinuko wrote:
> I haven't looked really deeply but it looks it's unsafe usage. Could either of
> you take a look?

lgtm

[kinuko, 2015-01-29 05:07:40]

On 2015/01/29 04:48:32, Timothy Loh wrote:
> On 2015/01/27 14:24:42, kinuko wrote:
> > I haven't looked really deeply but it looks it's unsafe usage. Could either
of
> > you take a look?
> 
> lgtm

Thanks!

[kinuko, 2015-01-29 05:07:45]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2015-01-29 05:08:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864143006/40001

[commit-bot: I haz the power, 2015-01-29 05:11:48]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189163

[kouhei (in TOK), 2015-01-29 05:21:55]

lgtm

[sof, 2015-12-02 13:32:41]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-12-02 13:32:41]

https://codereview.chromium.org/864143006/diff/40001/Source/core/css/CSSPrimi...
File Source/core/css/CSSPrimitiveValue.cpp (right):

https://codereview.chromium.org/864143006/diff/40001/Source/core/css/CSSPrimi...
Source/core/css/CSSPrimitiveValue.cpp:219:
AtomicallyInitializedStaticReference(ThreadSpecific<CSSTextCache>, cache, new
ThreadSpecific<CSSTextCache>());
fwiw, http/tests/misc/client-hints-picture-source-removal.html is a test that
exercises non-main thread use of cssTextCache().