Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1667773002: Support different project toolchains (Closed)

Created:
4 years, 10 months ago by Tomasz Moniuszko
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support different project toolchains Solution may contain projects configured to use non-default toolchains. For instance solution with "Debug|Win32" configuration may contain some projects with "Debug|x64" configuration. BUG=305761 Committed: https://crrev.com/bc312ac4dc1bbf5bf6ed5efc47595c08c8a48401 Cr-Commit-Position: refs/heads/master@{#373503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -66 lines) Patch
M tools/gn/visual_studio_writer.h View 2 chunks +22 lines, -9 lines 0 comments Download
M tools/gn/visual_studio_writer.cc View 10 chunks +48 lines, -27 lines 0 comments Download
M tools/gn/visual_studio_writer_unittest.cc View 2 chunks +24 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tomasz Moniuszko
4 years, 10 months ago (2016-02-03 15:47:24 UTC) #2
brettw
lgtm
4 years, 10 months ago (2016-02-03 18:54:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667773002/1
4 years, 10 months ago (2016-02-04 09:33:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 10:53:40 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 10:55:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc312ac4dc1bbf5bf6ed5efc47595c08c8a48401
Cr-Commit-Position: refs/heads/master@{#373503}

Powered by Google App Engine
This is Rietveld 408576698