Implement some methods of ChromeBrowserState.

ios/chrome/browser/browser_state/chrome_browser_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_BROWSER_STATE_CHROME_BROWSER_STATE_H_
 #define IOS_CHROME_BROWSER_BROWSER_STATE_CHROME_BROWSER_STATE_H_
 
 #include <map>
 #include <string>
 
 #include "base/callback_forward.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "ios/web/public/browser_state.h"
 #include "net/url_request/url_request_job_factory.h"
 
 class ChromeBrowserStateIOData;
 class PrefProxyConfigTracker;
 class PrefService;
 class TestChromeBrowserState;
+class TestChromeBrowserStateManager;
 
 namespace base {
 class SequencedTaskRunner;
 class Time;
 }
 
 namespace net {
 class SSLConfigService;
 class URLRequestInterceptor;
 }
 
 namespace syncable_prefs {
 class PrefServiceSyncable;
 }
 
 namespace web {
 class WebUIIOS;
 }
 
 namespace ios {
 
 enum class ChromeBrowserStateType {
   REGULAR_BROWSER_STATE,
   INCOGNITO_BROWSER_STATE,
 };
 
 // This class is a Chrome-specific extension of the BrowserState interface.
 class ChromeBrowserState : public web::BrowserState {
  public:
-  ~ChromeBrowserState() override {}
+  ~ChromeBrowserState() override;
 
   // Returns the ChromeBrowserState corresponding to the given BrowserState.
   static ChromeBrowserState* FromBrowserState(BrowserState* browser_state);
 
   // Returns the ChromeBrowserState corresponding to the given WebUIIOS.
   static ChromeBrowserState* FromWebUIIOS(web::WebUIIOS* web_ui);
 
   // Returns sequenced task runner where browser state dependent I/O
   // operations should be performed.
-  virtual scoped_refptr<base::SequencedTaskRunner> GetIOTaskRunner() = 0;
+  virtual scoped_refptr<base::SequencedTaskRunner> GetIOTaskRunner();
 
   // Returns the original "recording" ChromeBrowserState. This method returns
   // |this| if the ChromeBrowserState is not incognito.
   virtual ChromeBrowserState* GetOriginalChromeBrowserState() = 0;
 
   // Returns true if the ChromeBrowserState is off-the-record or if the
   // associated off-the-record browser state has been created.
   // Calling this method does not create the off-the-record browser state if it
   // does not already exist.
   virtual bool HasOffTheRecordChromeBrowserState() const = 0;
@@ skipping 15 matching lines @@
   // for OffTheRecord browser states.
   virtual PrefService* GetOffTheRecordPrefs() = 0;
 
   // Allows access to ChromeBrowserStateIOData without going through
   // ResourceContext that is not compiled on iOS. This method must be called on
   // UI thread, but the returned object must only be accessed on the IO thread.
   virtual ChromeBrowserStateIOData* GetIOData() = 0;
 
   // Retrieves a pointer to the PrefService that manages the preferences as
   // a syncable_prefs::PrefServiceSyncable.
-  virtual syncable_prefs::PrefServiceSyncable* GetSyncablePrefs() = 0;
+  virtual syncable_prefs::PrefServiceSyncable* GetSyncablePrefs();
 
   // Deletes all network related data since |time|. It deletes transport
   // security state since |time| and it also deletes HttpServerProperties data.
   // Works asynchronously, however if the |completion| callback is non-null, it
   // will be posted on the UI thread once the removal process completes.
   // Be aware that theoretically it is possible that |completion| will be
   // invoked after the Profile instance has been destroyed.
   virtual void ClearNetworkingHistorySince(base::Time time,
                                            const base::Closure& completion) = 0;
 
@@ skipping 15 matching lines @@
           protocol_handlers,
       ScopedVector<net::URLRequestInterceptor> request_interceptors) = 0;
 
   // Creates a isolated net::URLRequestContextGetter. Should only be called once
   // per partition_path per browser state object.
   virtual net::URLRequestContextGetter* CreateIsolatedRequestContext(
       const base::FilePath& partition_path) = 0;
 
   // Returns the current ChromeBrowserState casted as a TestChromeBrowserState
   // or null if it is not a TestChromeBrowserState.
-  virtual TestChromeBrowserState* AsTestChromeBrowserState() = 0;
+  virtual TestChromeBrowserState* AsTestChromeBrowserState();

[droger, 2016/02/03 16:20:48]

It would be great to remove this:
1) It seems this method is only called in one place, and it is in code related
to the data proxy, which is now deprecated.
2) I don't think it's a good design to have this method

Could you maybe try to see if the tests pass if it is removed? And maybe file a
bug to remove it if it is not trivial.

[sdefresne, 2016/02/03 16:32:05]

=> crbug.com/583682

+
+  // web::BrowserState
+  net::URLRequestContextGetter* GetRequestContext() override;
 
  protected:
-  ChromeBrowserState() {}
+  ChromeBrowserState();
 
  private:
+  friend class ::TestChromeBrowserState;
+  friend class ::TestChromeBrowserStateManager;
+
+  scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeBrowserState);
 };
 
 }  // namespace ios
 
 #endif  // IOS_CHROME_BROWSER_BROWSER_STATE_CHROME_BROWSER_STATE_H_