third_party/WebKit/Source/bindings/templates/attributes.cpp - Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp

Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved the [LenientThis] test to http/tests/. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_interface.py ('k') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/attributes.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp b/third_party/WebKit/Source/bindings/templates/attributes.cpp

index 68b988caa9ecf318a6fae2820930c1ce1b4b2f07..e72b9ed23601f0a80e55bfa077c537b8bc410cf7 100644

--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp

+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp

@@ -459,10 +459,7 @@ bool {{v8_class}}::PrivateScript::{{attribute.name}}AttributeSetter(LocalFrame*

'%sV8Internal::%sConstructorGetterCallback' % (cpp_class_or_partial, attribute.name)

if attribute.needs_constructor_getter_callback else

'v8ConstructorAttributeGetter' %}

-{% set setter_callback =

- '%sV8Internal::%sAttributeSetterCallback' % (cpp_class_or_partial, attribute.name)

- if attribute.needs_constructor_setter_callback else

- '%sV8Internal::%sConstructorAttributeSetterCallback' % (cpp_class_or_partial, cpp_class) %}

+{% set setter_callback = '0' %}

{% else %}{# regular attributes #}

{% set getter_callback = '%sV8Internal::%sAttributeGetterCallback' %

(cpp_class_or_partial, attribute.name) %}