third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved the [LenientThis] test to http/tests/. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_attributes.py ('k') | third_party/WebKit/Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index 35edaee63b7760b5f65161ff9e53d07ba6b0aabc..c717e7cd759e85018a7e2f55a12d29d840ce897b 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -302,9 +302,13 @@ def interface_context(interface):

attribute['is_data_type_property'] and

attribute['should_be_exposed_to_script']

for attribute in attributes),

- 'has_constructor_attributes': any(attribute['constructor_type'] for attribute in attributes),

- 'needs_constructor_setter_callback': any(attribute['constructor_type'] == attribute['name'] for attribute in attributes),

- 'has_replaceable_attributes': any(attribute['is_replaceable'] for attribute in attributes),

+ 'has_constructor_attributes': any(

+ attribute['constructor_type']

+ for attribute in attributes),

+ 'has_replaceable_attributes': any(

+ attribute['is_replaceable'] and

+ not attribute['is_data_type_property']

+ for attribute in attributes),

})

# Methods