third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h - Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved the [LenientThis] test to http/tests/. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/w3c/cross-origin-objects-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

index e629ba66d518d6a2c6662d90de75dc59d4da4e75..9bbe38439e6381617f69814cd142068873a1db6c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

@@ -62,7 +62,7 @@ public:

DoNotCheckHolder,

};

- // AttributeConfiguration translates into calls to SetAccessor() on either

+ // AttributeConfiguration translates into calls to SetNativeDataProperty() on either

// the instance or the prototype ObjectTemplate, based on |instanceOrPrototypeConfiguration|.

struct AttributeConfiguration {

AttributeConfiguration& operator=(const AttributeConfiguration&) = delete;