third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp - Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved the [LenientThis] test to http/tests/. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h ('k') | third_party/WebKit/Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

index df87a6750718fafb712459b4b2c42febdcd4c28d..5c807483a15ed1c44f3948e8d5028a4e49cbf640 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

@@ -54,9 +54,9 @@ void installAttributeInternal(v8::Isolate* isolate, v8::Local<v8::ObjectTemplate

ASSERT(attribute.propertyLocationConfiguration);

if (attribute.propertyLocationConfiguration & V8DOMConfiguration::OnInstance)

- instanceTemplate->SetAccessor(name, getter, setter, data, static_cast<v8::AccessControl>(attribute.settings), static_cast<v8::PropertyAttribute>(attribute.attribute));

+ instanceTemplate->SetNativeDataProperty(name, getter, setter, data, static_cast<v8::PropertyAttribute>(attribute.attribute), v8::Local<v8::AccessorSignature>(), static_cast<v8::AccessControl>(attribute.settings));

if (attribute.propertyLocationConfiguration & V8DOMConfiguration::OnPrototype)

- prototypeTemplate->SetAccessor(name, getter, setter, data, static_cast<v8::AccessControl>(attribute.settings), static_cast<v8::PropertyAttribute>(attribute.attribute));

+ prototypeTemplate->SetNativeDataProperty(name, getter, setter, data, static_cast<v8::PropertyAttribute>(attribute.attribute), v8::Local<v8::AccessorSignature>(), static_cast<v8::AccessControl>(attribute.settings));

if (attribute.propertyLocationConfiguration & V8DOMConfiguration::OnInterface)

ASSERT_NOT_REACHED();

}