Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1667453002: Remove flags for ES2015 features shipped in M48 (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove flags for ES2015 features shipped in M48 This removes --harmony-completion, --harmony-concat-spreadable, and --harmony-tolength and moves the appropriate tests from harmony/ to es6/. Committed: https://crrev.com/8a4a5bf9e0c91cf8d3c17c2293ba3e7f00242b74 Cr-Commit-Position: refs/heads/master@{#33712}

Patch Set 1 #

Patch Set 2 : Mark failing ignition/arm64 test as flaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1102 lines) Patch
M src/bootstrapper.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M src/builtins.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/js/array.js View 25 chunks +23 lines, -25 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/regexp.js View 4 chunks +2 lines, -7 lines 0 comments Download
M src/js/symbol.js View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/rewriter.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/array-concat.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/array-length.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-for.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/completion.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-tolength.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/array-concat.js View 1 chunk +0 lines, -874 lines 0 comments Download
M test/mjsunit/harmony/block-for-sloppy.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/harmony/completion.js View 1 chunk +0 lines, -150 lines 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-516775.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
adamk
4 years, 10 months ago (2016-02-03 01:02:04 UTC) #2
rossberg
lgtm
4 years, 10 months ago (2016-02-03 03:14:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667453002/1
4 years, 10 months ago (2016-02-03 18:42:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14819)
4 years, 10 months ago (2016-02-03 19:21:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667453002/1
4 years, 10 months ago (2016-02-03 19:32:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14823)
4 years, 10 months ago (2016-02-03 19:40:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667453002/20001
4 years, 10 months ago (2016-02-03 19:45:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 20:51:33 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 20:51:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a4a5bf9e0c91cf8d3c17c2293ba3e7f00242b74
Cr-Commit-Position: refs/heads/master@{#33712}

Powered by Google App Engine
This is Rietveld 408576698