Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Camille's review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index df0f7a1e7b7128331b36debd5882b31dd4f37bd5..55f936ab92e8c0dc04a1e92faebbcf33c3324d84 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -227,8 +227,13 @@ void NavigationRequest::BeginNavigation() {
}
void NavigationRequest::CreateNavigationHandle() {
- navigation_handle_ = NavigationHandleImpl::Create(
- common_params_.url, frame_tree_node_, common_params_.navigation_start);
+ // TODO(nasko): Update the NavigationHandle creation to ensure that the
+ // proper values are specified for is_synchronous and is_srcdoc.
+ navigation_handle_ =
+ NavigationHandleImpl::Create(common_params_.url, frame_tree_node_,
+ false, // is_synchronous
+ false, // is_srcdoc
+ common_params_.navigation_start);
}
void NavigationRequest::TransferNavigationHandleOwnership(
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl_unittest.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698