content/browser/frame_host/navigation_handle_impl_unittest.cc - Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl_unittest.cc

Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on Camille's review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl_browsertest.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_handle_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_handle_impl_unittest.cc b/content/browser/frame_host/navigation_handle_impl_unittest.cc

index ee999cb31b06a0f9fcfb7c50ab0f75e92fe0ef67..6f81b08a7a8fd09e8ea0993c09f6006526b711d1 100644

--- a/content/browser/frame_host/navigation_handle_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_handle_impl_unittest.cc

@@ -54,7 +54,8 @@ class NavigationHandleImplTest : public RenderViewHostImplTestHarness {

void SetUp() override {

RenderViewHostImplTestHarness::SetUp();

test_handle_ = NavigationHandleImpl::Create(

- GURL(), main_test_rfh()->frame_tree_node(), base::TimeTicks::Now());

+ GURL(), main_test_rfh()->frame_tree_node(), false, false,

+ base::TimeTicks::Now());

}

void TearDown() override {