Chromium Code Reviews| Index: content/browser/frame_host/navigation_request.cc |
| diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc |
| index df0f7a1e7b7128331b36debd5882b31dd4f37bd5..55f936ab92e8c0dc04a1e92faebbcf33c3324d84 100644 |
| --- a/content/browser/frame_host/navigation_request.cc |
| +++ b/content/browser/frame_host/navigation_request.cc |
| @@ -227,8 +227,13 @@ void NavigationRequest::BeginNavigation() { |
| } |
| void NavigationRequest::CreateNavigationHandle() { |
| - navigation_handle_ = NavigationHandleImpl::Create( |
| - common_params_.url, frame_tree_node_, common_params_.navigation_start); |
| + // TODO(nasko): Update the NavigationHandle creation to ensure that the |
| + // proper values are specified for is_synchronous and is_srcdoc. |
| + navigation_handle_ = |
| + NavigationHandleImpl::Create(common_params_.url, frame_tree_node_, |
| + false, // is_synchronous |
|
clamy
2016/02/08 12:54:58
Can a browser-initiated nav count as synchronous?
nasko
2016/02/08 16:58:55
I don't think we can equivalate no network request
clamy
2016/02/09 10:45:25
Acknowledged for the first concern.
For the secon
|
| + false, // is_srcdoc |
| + common_params_.navigation_start); |
| } |
| void NavigationRequest::TransferNavigationHandleOwnership( |