Add methods to NavigationHandle to allow refactoring webNavigation to use it.

content/browser/frame_host/navigation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_request.h"
 
 #include <utility>
 
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
@@ skipping 209 matching lines @@
   }
 
   // There is no need to make a network request for this navigation, so commit
   // it immediately.
   state_ = RESPONSE_STARTED;
   frame_tree_node_->navigator()->CommitNavigation(
       frame_tree_node_, nullptr, scoped_ptr<StreamHandle>());
 }
 
 void NavigationRequest::CreateNavigationHandle() {
-  navigation_handle_ = NavigationHandleImpl::Create(
-      common_params_.url, frame_tree_node_, common_params_.navigation_start);
+  // TODO(nasko): Update the NavigationHandle creation to ensure that the
+  // proper values are specified for is_synchronous and is_srcdoc.
+  navigation_handle_ =
+      NavigationHandleImpl::Create(common_params_.url, frame_tree_node_,
+                                   false,  // is_synchronous

[clamy, 2016/02/08 12:54:58]

Can a browser-initiated nav count as synchronous? If so, can you just get
whether it's synchronous or not using ShouldMakeNetworkRequestForURL? This
filter out about:blank, javascript urls, empty urls and data urls right now.

For the srcdoc thing, doesn't what is done in DidStartProvisionalLoad work here
(ie url.spec() == kAboutSrcDocURL)?

[nasko, 2016/02/08 16:58:55]

I don't think we can equivalate no network request with synchronous navigations.
I think data: URLs are not synchronous, but have to double check. Also, I recall
Charlie and Daniel talking recently that "about:blank" might not be synchronous
if it is not the first commit. To be on the safe side, I decided not to touch
this area in this CL and that's why it has a TODO.
Browser initiated navigation cannot be to srcdoc, as it is an iframe attribute,
right?

[clamy, 2016/02/09 10:45:25]

Acknowledged for the first concern.

For the second one, note that this method is also called in renderer-initiated
navigations. However we can leave the detection of srcdoc navigations for a
later patch.

+                                   false,  // is_srcdoc
+                                   common_params_.navigation_start);
 }
 
 void NavigationRequest::TransferNavigationHandleOwnership(
     RenderFrameHostImpl* render_frame_host) {
   render_frame_host->SetNavigationHandle(std::move(navigation_handle_));
 }
 
 void NavigationRequest::OnRequestRedirected(
     const net::RedirectInfo& redirect_info,
     const scoped_refptr<ResourceResponse>& response) {
@@ skipping 112 matching lines @@
       browser_context, navigating_frame_host->GetSiteInstance());
   DCHECK(partition);
 
   ServiceWorkerContextWrapper* service_worker_context =
       static_cast<ServiceWorkerContextWrapper*>(
           partition->GetServiceWorkerContext());
   navigation_handle_->InitServiceWorkerHandle(service_worker_context);
 }
 
 }  // namespace content