Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: content/public/browser/navigation_handle.h

Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 8d0c6d98a2e7fb3c0d41e0292a3c592a8df25bc4..9646960a29c6baf7e7bf2efd46cfbc4fa0bd1dcf 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -41,6 +41,33 @@ class CONTENT_EXPORT NavigationHandle {
// This remains constant over the navigation lifetime.
virtual bool IsInMainFrame() = 0;
+ // Whether the navigation is taking place in a frame, which is a direct child
Charlie Reis 2016/02/04 20:46:05 nit: in a frame that is a (The current phrasing m
nasko 2016/02/04 23:36:59 Done.
+ // of the main frame. This remains constant over the navigation lifetime.
+ virtual bool IsParentMainFrame() = 0;
+
+ // Whether the navigation is synchronous or not. Examples of synchronous
+ // navigations are:
+ // * reference fragment navigations
+ // * pushState/popState
+ // * navigating to about:blank
Charlie Reis 2016/02/04 20:46:05 Double check with dcheng on the about:blank case.
nasko 2016/02/04 23:36:59 Removing for now, to ensure I'm not misleading.
+ virtual bool IsSynchronousNavigation() = 0;
+
+ // Whether the navigation is for iframe with srcdoc attribute.
Charlie Reis 2016/02/04 20:46:05 nit: for an
nasko 2016/02/04 23:36:59 Done.
+ virtual bool IsSrcdoc() = 0;
+
+ // Whether the navigation has encountered a server redirect or not.
Charlie Reis 2016/02/04 20:46:05 Hmm, I'm not sure this should be in "available at
nasko 2016/02/04 23:36:59 Good point. It was clustered with the rest of the
+ virtual bool WasRedirected() = 0;
Charlie Reis 2016/02/04 20:46:05 Hmm, I always like to be explicit about server vs
nasko 2016/02/04 23:36:59 Done.
+
+ // Returns the FrameTreeNode ID for the frame in which the navigation is
+ // performed. This ID is browser-global and uniquely identifies a frame that
+ // hosts content. The identifier is fixed at the creation of the frame and
+ // stays constant for the lifetime of the frame.
+ virtual int GetFrameTreeNodeId() = 0;
+
+ // Retruns the FrameTreeNode ID for the parent frame. If this navigation is
+ // taking place in the main frame, the value returned is -1.
+ virtual int GetParentFrameTreeNodeId() = 0;
+
// The WebContents the navigation is taking place in.
WebContents* GetWebContents();

Powered by Google App Engine
This is Rietveld 408576698