Add methods to NavigationHandle to allow refactoring webNavigation to use it.

content/public/browser/navigation_handle.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 
 #include "content/common/content_export.h"
 #include "content/public/browser/navigation_throttle.h"
 #include "content/public/common/referrer.h"
@@ skipping 23 matching lines @@
   // some may change during navigation (e.g. due to server redirects).
 
   // The URL the frame is navigating to. This may change during the navigation
   // when encountering a server redirect.
   virtual const GURL& GetURL() = 0;
 
   // Whether the navigation is taking place in the main frame or in a subframe.
   // This remains constant over the navigation lifetime.
   virtual bool IsInMainFrame() = 0;
 
+  // Whether the navigation is taking place in a frame, which is a direct child

[Charlie Reis, 2016/02/04 20:46:05]

nit: in a frame that is a

(The current phrasing makes the reader stop at "in a frame" without realizing
that the second phrase is a qualifier.)

[nasko, 2016/02/04 23:36:59]

Done.

+  // of the main frame. This remains constant over the navigation lifetime.
+  virtual bool IsParentMainFrame() = 0;
+
+  // Whether the navigation is synchronous or not. Examples of synchronous
+  // navigations are:
+  // * reference fragment navigations
+  // * pushState/popState
+  // * navigating to about:blank

[Charlie Reis, 2016/02/04 20:46:05]

Double check with dcheng on the about:blank case.  I can never keep track.

[nasko, 2016/02/04 23:36:59]

Removing for now, to ensure I'm not misleading.

+  virtual bool IsSynchronousNavigation() = 0;
+
+  // Whether the navigation is for iframe with srcdoc attribute.

[Charlie Reis, 2016/02/04 20:46:05]

nit: for an

[nasko, 2016/02/04 23:36:59]

Done.

+  virtual bool IsSrcdoc() = 0;
+
+  // Whether the navigation has encountered a server redirect or not.

[Charlie Reis, 2016/02/04 20:46:05]

Hmm, I'm not sure this should be in "available at navigation start time" group. 
Seems like we wouldn't know until later, and most of the methods in this section
don't change over time.

[nasko, 2016/02/04 23:36:59]

Good point. It was clustered with the rest of the APIs I was adding and missed
the headings. Moved.

+  virtual bool WasRedirected() = 0;

[Charlie Reis, 2016/02/04 20:46:05]

Hmm, I always like to be explicit about server vs client redirect if I can,
since those are very different cases.  Maybe WasServerRedirect (if it
intentionally excludes the client redirect case)?

[nasko, 2016/02/04 23:36:59]

Done.

+
+  // Returns the FrameTreeNode ID for the frame in which the navigation is
+  // performed. This ID is browser-global and uniquely identifies a frame that
+  // hosts content. The identifier is fixed at the creation of the frame and
+  // stays constant for the lifetime of the frame.
+  virtual int GetFrameTreeNodeId() = 0;
+
+  // Retruns the FrameTreeNode ID for the parent frame. If this navigation is
+  // taking place in the main frame, the value returned is -1.
+  virtual int GetParentFrameTreeNodeId() = 0;
+
   // The WebContents the navigation is taking place in.
   WebContents* GetWebContents();
 
   // The time the navigation started, recorded either in the renderer or in the
   // browser process. Corresponds to Navigation Timing API.
   virtual const base::TimeTicks& NavigationStart() = 0;
 
   // Parameters available at network request start time ------------------------
   //
   // The following parameters are only available when the network request is
@@ skipping 84 matching lines @@
   virtual NavigationThrottle::ThrottleCheckResult
   CallWillRedirectRequestForTesting(const GURL& new_url,
                                     bool new_method_is_post,
                                     const GURL& new_referrer_url,
                                     bool new_is_external_protocol) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_