Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1667083002: Reland of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. BUG= Committed: https://crrev.com/b6a353129a744440b05441b675dd12ac6068abd3 Cr-Commit-Position: refs/heads/master@{#33737}

Patch Set 1 #

Patch Set 2 : The actual diff to the original patch #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M src/api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +12 lines, -13 lines 0 comments Download
M src/objects.cc View 4 chunks +13 lines, -17 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-04 13:46:40 UTC) #2
Igor Sheludko
lgtm
4 years, 10 months ago (2016-02-04 14:03:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667083002/40001
4 years, 10 months ago (2016-02-04 14:03:49 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-04 14:47:18 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 14:47:57 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b6a353129a744440b05441b675dd12ac6068abd3
Cr-Commit-Position: refs/heads/master@{#33737}

Powered by Google App Engine
This is Rietveld 408576698