Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: src/lookup.cc

Issue 1667083002: Reland of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/lookup.h" 5 #include "src/lookup.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 "DeletingProperty"); 285 "DeletingProperty");
286 holder_map_ = handle(holder->map(), isolate_); 286 holder_map_ = handle(holder->map(), isolate_);
287 ReloadPropertyInformation(); 287 ReloadPropertyInformation();
288 } 288 }
289 // TODO(verwaest): Get rid of the name_ argument. 289 // TODO(verwaest): Get rid of the name_ argument.
290 JSReceiver::DeleteNormalizedProperty(holder, name_, number_); 290 JSReceiver::DeleteNormalizedProperty(holder, name_, number_);
291 if (holder->IsJSObject()) { 291 if (holder->IsJSObject()) {
292 JSObject::ReoptimizeIfPrototype(Handle<JSObject>::cast(holder)); 292 JSObject::ReoptimizeIfPrototype(Handle<JSObject>::cast(holder));
293 } 293 }
294 } 294 }
295 state_ = NOT_FOUND;
295 } 296 }
296 297
297 298
298 void LookupIterator::TransitionToAccessorProperty( 299 void LookupIterator::TransitionToAccessorProperty(
299 AccessorComponent component, Handle<Object> accessor, 300 AccessorComponent component, Handle<Object> accessor,
300 PropertyAttributes attributes) { 301 PropertyAttributes attributes) {
301 DCHECK(!accessor->IsNull()); 302 DCHECK(!accessor->IsNull());
302 // Can only be called when the receiver is a JSObject. JSProxy has to be 303 // Can only be called when the receiver is a JSObject. JSProxy has to be
303 // handled via a trap. Adding properties to primitive values is not 304 // handled via a trap. Adding properties to primitive values is not
304 // observable. 305 // observable.
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
668 // Fall through. 669 // Fall through.
669 default: 670 default:
670 return NOT_FOUND; 671 return NOT_FOUND;
671 } 672 }
672 UNREACHABLE(); 673 UNREACHABLE();
673 return state_; 674 return state_;
674 } 675 }
675 676
676 } // namespace internal 677 } // namespace internal
677 } // namespace v8 678 } // namespace v8
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698