[serializer] add synchronize codes to detect mismatch.

[serializer] add synchronize codes to detect mismatch.

Synchronize calls in the heap iterator have been put there for the
serializer, which never actually made use of them. This CL fixes that.

R=vogelheim@chromium.org

Committed: https://crrev.com/8208dd6a6bad1efcf2ed14250a541ab35c6e65c6
Cr-Commit-Position: refs/heads/master@{#33736}

[vogelheim, 2016-02-04 11:00:23]

lgtm

Just for my understanding: You serialize&expect a constant value for all
synchronization points, rather than using the tag to distinguish different synch
points. Why?

[Yang, 2016-02-04 12:42:44]

On 2016/02/04 11:00:23, vogelheim wrote:
> lgtm
> 
> Just for my understanding: You serialize&expect a constant value for all
> synchronization points, rather than using the tag to distinguish different
synch
> points. Why?

Because in ReadData we explicitly look for the kSynchronize bytecode and crash
if we find it. If we use the tag, we might interpret it as a different bytecode
and simply carry on. The crash would look cryptic.

[Yang, 2016-02-04 12:42:58]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-02-04 12:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 12:43:04]

This CL has an open dependency (Issue 1667693002 Patch 20001). Please resolve
the dependency and try again.

[Yang, 2016-02-04 13:51:47]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-02-04 13:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667063002/1

[commit-bot: I haz the power, 2016-02-04 14:22:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-04 14:22:32]

Description was changed from

==========
[serializer] add synchronize codes to detect mismatch.

Synchronize calls in the heap iterator have been put there for the
serializer, which never actually made use of them. This CL fixes that.

R=vogelheim@chromium.org
==========

to

==========
[serializer] add synchronize codes to detect mismatch.

Synchronize calls in the heap iterator have been put there for the
serializer, which never actually made use of them. This CL fixes that.

R=vogelheim@chromium.org

Committed: https://crrev.com/8208dd6a6bad1efcf2ed14250a541ab35c6e65c6
Cr-Commit-Position: refs/heads/master@{#33736}
==========

[commit-bot: I haz the power, 2016-02-04 14:22:32]

Patchset 1 (id:??) landed as
https://crrev.com/8208dd6a6bad1efcf2ed14250a541ab35c6e65c6
Cr-Commit-Position: refs/heads/master@{#33736}