[interpreter] do not serialize bytecode for snapshot.

[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
w/o --ignition:   484k
w/ --ignition:    537k
bytecode removed: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/34645da5b91ba371aea6e31ffc6db93b01344d45
Cr-Commit-Position: refs/heads/master@{#33734}

[Yang, 2016-02-03 11:28:48]

Description was changed from

==========
[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
without --ignition: 484k
with --ignition:    537k
with --ignition but without bytecode: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org
==========

to

==========
[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
w/o --ignition:   484k
w/ --ignition:    537k
bytecode removed: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org
==========

[rmcilroy, 2016-02-03 12:07:15]

lgtm for now (although we should consider replacing the natives_blob of JS
source with pre-compiled bytecode once we are getting closer to shipping
ignition.

[Michael Starzinger, 2016-02-03 12:39:26]

LGTM with one suggestion.

https://codereview.chromium.org/1667693002/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1667693002/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:1707: obj ==
builtins->builtin(Builtins::kInterpreterEntryTrampoline)) {
nit: Can we use the Code::is_interpreter_entry_trampoline predicate here?

[Yang, 2016-02-03 12:40:19]

On 2016/02/03 12:07:15, rmcilroy wrote:
> lgtm for now (although we should consider replacing the natives_blob of JS
> source with pre-compiled bytecode once we are getting closer to shipping
> ignition.

Once we are there, we can ship without natives blob at all, since all bytecode
would be contained in the snapshot blob.

[Yang, 2016-02-03 12:40:22]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-02-03 12:40:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667693002/1

[commit-bot: I haz the power, 2016-02-03 12:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 12:53:16]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Yang, 2016-02-04 09:05:28]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-04 09:05:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1667693002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-02-04 09:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667693002/20001

[commit-bot: I haz the power, 2016-02-04 09:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 09:30:54]

Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/897)
  v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Yang, 2016-02-04 10:08:53]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-04 10:08:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1667693002/#ps80001
(title: "turn off flag")

[commit-bot: I haz the power, 2016-02-04 10:09:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667693002/80001

[commit-bot: I haz the power, 2016-02-04 10:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 10:49:38]

Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/903)
  v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Yang, 2016-02-04 13:06:36]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-04 13:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1667693002/#ps100001
(title: "fix heap snapshot tests")

[commit-bot: I haz the power, 2016-02-04 13:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667693002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667693002/100001

[Yang, 2016-02-04 13:07:24]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2016-02-04 13:08:00]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-04 13:08:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1667693002/#ps120001
(title: "turn flag off")

[commit-bot: I haz the power, 2016-02-04 13:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667693002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667693002/120001

[commit-bot: I haz the power, 2016-02-04 13:49:34]

Description was changed from

==========
[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
w/o --ignition:   484k
w/ --ignition:    537k
bytecode removed: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org
==========

to

==========
[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
w/o --ignition:   484k
w/ --ignition:    537k
bytecode removed: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org
==========

[commit-bot: I haz the power, 2016-02-04 13:49:34]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-04 13:50:00]

Description was changed from

==========
[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
w/o --ignition:   484k
w/ --ignition:    537k
bytecode removed: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org
==========

to

==========
[interpreter] do not serialize bytecode for snapshot.

Code compiled during snapshot are overwhelmingly for functions
that are only used for bootstrapping. It makes no sense to
include them in the startup snapshot, which bloats up the snapshot size
and slows down deserialization.

Snapshot sizes for comparison, for ia32:
w/o --ignition:   484k
w/ --ignition:    537k
bytecode removed: 489k

R=rmcilroy@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/34645da5b91ba371aea6e31ffc6db93b01344d45
Cr-Commit-Position: refs/heads/master@{#33734}
==========

[commit-bot: I haz the power, 2016-02-04 13:50:01]

Patchset 7 (id:??) landed as
https://crrev.com/34645da5b91ba371aea6e31ffc6db93b01344d45
Cr-Commit-Position: refs/heads/master@{#33734}