third_party/WebKit/Source/devtools/front_end/common/Settings.js - Issue 1666573002: [DevTools] Polyfill Object.observe for old frontends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Settings.js

Issue 1666573002: [DevTools] Polyfill Object.observe for old frontends. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/common/Settings.js

diff --git a/third_party/WebKit/Source/devtools/front_end/common/Settings.js b/third_party/WebKit/Source/devtools/front_end/common/Settings.js

index 6944a294f6c158b9c92f5c5ad68de6ceca345690..7869c34aa7fef76197adf7a32e34939472bf0ac7 100644

--- a/third_party/WebKit/Source/devtools/front_end/common/Settings.js

+++ b/third_party/WebKit/Source/devtools/front_end/common/Settings.js

@@ -266,7 +266,7 @@ WebInspector.Setting.prototype = {

try {

this._value = JSON.parse(this._storage.get(this._name));

} catch(e) {

- this.remove();

+ this._storage.remove(this._name);

}

return this._value;

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/devtools.js » ('j') | no next file with comments »