Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1666553002: Make QUIC's SerializedPacket contain QuicFrames, rather than a pointer (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@113205205
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QUIC's SerializedPacket contain QuicFrames, rather than a pointer to QuicFrames. No functional change. Estimated to save ~0.8% CPU. Merge internal change: 113222997 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -69 lines) Patch
M net/quic/congestion_control/general_loss_algorithm_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/quic_connection.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_connection_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 6 chunks +7 lines, -13 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-03 02:27:54 UTC) #1
Ryan Hamilton
4 years, 10 months ago (2016-02-03 05:30:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698