Issue 1660253003: factor out path id + packet number packing code from the QUIC aead code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1660253003: factor out path id + packet number packing code from the QUIC aead code (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)

Modified:
4 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@113179972

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

factor out path id + packet number packing code from the QUIC aead code into QuicUtils::PackPathIdAndPacketNumber to reduce code duplication (which is doubled in Chromium because of NSS & OpenSSL versions of this code). Merge internal change: 113205205 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Fix bug #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -32 lines)			Patch
M	net/quic/crypto/aead_base_decrypter_nss.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	net/quic/crypto/aead_base_decrypter_openssl.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	net/quic/crypto/aead_base_encrypter_nss.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	net/quic/crypto/aead_base_encrypter_openssl.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	net/quic/quic_utils.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/quic_utils.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1665693002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages