Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1666513002: Promote CookieMonster::DeleteCanonicalCookieAsync to CookieStore. (Closed)

Created:
4 years, 10 months ago by mmenke
Modified:
4 years, 10 months ago
Reviewers:
droger, Mike West, sky
CC:
cbentzel+watch_chromium.org, chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@cookie_monster13
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promote CookieMonster::DeleteCanonicalCookieAsync to CookieStore. This is part of an effort to get rid of GetCookieMonster, and make classes that care abotu cookies only depend on CookieStore. TBR=sky@chromium.org BUG=579653 Committed: https://crrev.com/24379d50fb80256588a925bfdd34679a71013f05 Cr-Commit-Position: refs/heads/master@{#373952}

Patch Set 1 #

Patch Set 2 : Fix Merge #

Patch Set 3 : More fixes, tests #

Patch Set 4 : Update comments #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -107 lines) Patch
M chrome/browser/browsing_data/browsing_data_cookie_helper.cc View 1 2 2 chunks +6 lines, -16 lines 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sessions/session_data_deleter.cc View 1 2 5 chunks +8 lines, -9 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M ios/net/cookies/cookie_store_ios_unittest.mm View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M net/cookies/cookie_monster.h View 1 2 5 chunks +4 lines, -9 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 2 6 chunks +27 lines, -28 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 2 3 4 7 chunks +7 lines, -41 lines 0 comments Download
M net/cookies/cookie_store.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M net/cookies/cookie_store_test_helpers.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M net/cookies/cookie_store_test_helpers.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M net/cookies/cookie_store_unittest.h View 1 2 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
mmenke
mkwst: Everything. droger: ios.
4 years, 10 months ago (2016-02-04 19:01:55 UTC) #9
droger
ios LGTM
4 years, 10 months ago (2016-02-05 09:04:01 UTC) #10
Mike West
LGTM, especially for aligning DeleteCallback and DeleteCookieCallback (by removing the latter). :)
4 years, 10 months ago (2016-02-05 09:04:02 UTC) #11
mmenke
[+sky]: TBRing you for trivial chrome/browser/sessions/session_data_deleter.cc change (No longer have to downcast a CookieStore to ...
4 years, 10 months ago (2016-02-05 16:59:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666513002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666513002/260001
4 years, 10 months ago (2016-02-05 22:20:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666513002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666513002/260001
4 years, 10 months ago (2016-02-05 22:46:27 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:260001)
4 years, 10 months ago (2016-02-05 23:50:27 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 23:52:25 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/24379d50fb80256588a925bfdd34679a71013f05
Cr-Commit-Position: refs/heads/master@{#373952}

Powered by Google App Engine
This is Rietveld 408576698