Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: net/cookies/cookie_monster.cc

Issue 1666513002: Promote CookieMonster::DeleteCanonicalCookieAsync to CookieStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cookie_monster13
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster.h ('k') | net/cookies/cookie_monster_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.cc
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc
index a2c71ff0c740eb26dc03fd60e2de14e229ed6322..fe5f13faa77ce1655c78ccabd99f5709589efb69 100644
--- a/net/cookies/cookie_monster.cc
+++ b/net/cookies/cookie_monster.cc
@@ -700,15 +700,15 @@ int CookieMonster::DeleteAllCreatedBetweenForHostTask::RunDeleteTask() {
}
// Task class for DeleteCanonicalCookie call.
-class CookieMonster::DeleteCanonicalCookieTask : public DeleteTask<bool> {
+class CookieMonster::DeleteCanonicalCookieTask : public DeleteTask<int> {
public:
DeleteCanonicalCookieTask(CookieMonster* cookie_monster,
const CanonicalCookie& cookie,
- const DeleteCookieCallback& callback)
- : DeleteTask<bool>(cookie_monster, callback), cookie_(cookie) {}
+ const DeleteCallback& callback)
+ : DeleteTask<int>(cookie_monster, callback), cookie_(cookie) {}
// DeleteTask:
- bool RunDeleteTask() override;
+ int RunDeleteTask() override;
protected:
~DeleteCanonicalCookieTask() override {}
@@ -719,7 +719,7 @@ class CookieMonster::DeleteCanonicalCookieTask : public DeleteTask<bool> {
DISALLOW_COPY_AND_ASSIGN(DeleteCanonicalCookieTask);
};
-bool CookieMonster::DeleteCanonicalCookieTask::RunDeleteTask() {
+int CookieMonster::DeleteCanonicalCookieTask::RunDeleteTask() {
return this->cookie_monster()->DeleteCanonicalCookie(cookie_);
}
@@ -926,15 +926,6 @@ void CookieMonster::GetAllCookiesForURLWithOptionsAsync(
DoCookieTaskForURL(task, url);
}
-void CookieMonster::DeleteCanonicalCookieAsync(
- const CanonicalCookie& cookie,
- const DeleteCookieCallback& callback) {
- scoped_refptr<DeleteCanonicalCookieTask> task =
- new DeleteCanonicalCookieTask(this, cookie, callback);
-
- DoCookieTask(task);
-}
-
void CookieMonster::FlushStore(const base::Closure& callback) {
base::AutoLock autolock(lock_);
if (initialized_ && store_.get())
@@ -998,6 +989,14 @@ void CookieMonster::DeleteCookieAsync(const GURL& url,
DoCookieTaskForURL(task, url);
}
+void CookieMonster::DeleteCanonicalCookieAsync(const CanonicalCookie& cookie,
+ const DeleteCallback& callback) {
+ scoped_refptr<DeleteCanonicalCookieTask> task =
+ new DeleteCanonicalCookieTask(this, cookie, callback);
+
+ DoCookieTask(task);
+}
+
void CookieMonster::DeleteAllCreatedBetweenAsync(
const Time& delete_begin,
const Time& delete_end,
@@ -1251,20 +1250,6 @@ int CookieMonster::DeleteAllCreatedBetweenForHost(const Time delete_begin,
}
-bool CookieMonster::DeleteCanonicalCookie(const CanonicalCookie& cookie) {
- base::AutoLock autolock(lock_);
-
- for (CookieMapItPair its = cookies_.equal_range(GetKey(cookie.Domain()));
- its.first != its.second; ++its.first) {
- // The creation date acts as our unique index...
- if (its.first->second->CreationDate() == cookie.CreationDate()) {
- InternalDeleteCookie(its.first, true, DELETE_COOKIE_EXPLICIT);
- return true;
- }
- }
- return false;
-}
-
bool CookieMonster::SetCookieWithOptions(const GURL& url,
const std::string& cookie_line,
const CookieOptions& options) {
@@ -1328,6 +1313,20 @@ void CookieMonster::DeleteCookie(const GURL& url,
}
}
+int CookieMonster::DeleteCanonicalCookie(const CanonicalCookie& cookie) {
+ base::AutoLock autolock(lock_);
+
+ for (CookieMapItPair its = cookies_.equal_range(GetKey(cookie.Domain()));
+ its.first != its.second; ++its.first) {
+ // The creation date acts as the unique index...
+ if (its.first->second->CreationDate() == cookie.CreationDate()) {
+ InternalDeleteCookie(its.first, true, DELETE_COOKIE_EXPLICIT);
+ return 1;
+ }
+ }
+ return 0;
+}
+
bool CookieMonster::SetCookieWithCreationTime(const GURL& url,
const std::string& cookie_line,
const base::Time& creation_time) {
« no previous file with comments | « net/cookies/cookie_monster.h ('k') | net/cookies/cookie_monster_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698