Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1666503002: Revert of Move Google3-specific stack limitation logic to template classes. Remove #ifdefs in other files. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move Google3-specific stack limitation logic to template classes. Remove #ifdefs in other files. (patchset #2 id:50001 of https://codereview.chromium.org/1656143003/ ) Reason for revert: See https://codereview.chromium.org/1665603002 Original issue's description: > Move Google3-specific stack limitation logic to template classes. Remove #ifdefs in other files. > > Does not change the public API. > > TBR=reed > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1656143003 > > Committed: https://skia.googlesource.com/skia/+/c92159c8250c62cc47b7b63686538d61d54d2835 TBR=mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/67e8bd207261ed4a4b30c4e488a6a2b6baf04d7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -66 lines) Patch
M include/core/SkTypes.h View 5 chunks +23 lines, -30 lines 0 comments Download
M include/private/SkTemplates.h View 7 chunks +12 lines, -36 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dogben
4 years, 10 months ago (2016-02-03 00:01:22 UTC) #1
Created Revert of Move Google3-specific stack limitation logic to template
classes. Remove #ifdefs in other files.

Powered by Google App Engine
This is Rietveld 408576698