Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1665603002: Revert of Roll src/third_party/skia/ 136f51762..c92159c82 (2 commits). (Closed)

Created:
4 years, 10 months ago by msw
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ 136f51762..c92159c82 (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/1660613002/ ) Reason for revert: Caused android builder compile to fail: https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/79064/steps/compile/logs/stdio Original issue's description: > Roll src/third_party/skia/ 136f51762..c92159c82 (2 commits). > > https://chromium.googlesource.com/skia.git/+log/136f51762755..c92159c8250c > > $ git log 136f51762..c92159c82 --date=short --no-merges --format='%ad %ae %s' > 2016-02-02 benjaminwagner Move Google3-specific stack limitation logic to template classes. Remove #ifdefs in other files. > 2016-02-02 scroggo Update SK_IMAGE_VERSION to test RAW > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=jcgregorio@google.com > > Committed: https://crrev.com/b1a75f2e7d37425dda092c443ecd33e5e3fd94d1 > Cr-Commit-Position: refs/heads/master@{#373062} TBR=jcgregorio@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6a0471dce5707290e91a67346321bf5ee8969eae Cr-Commit-Position: refs/heads/master@{#373080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Created Revert of Roll src/third_party/skia/ 136f51762..c92159c82 (2 commits).
4 years, 10 months ago (2016-02-02 23:38:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665603002/1
4 years, 10 months ago (2016-02-02 23:46:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 23:53:31 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a0471dce5707290e91a67346321bf5ee8969eae Cr-Commit-Position: refs/heads/master@{#373080}
4 years, 10 months ago (2016-02-02 23:54:50 UTC) #6
jcgregorio
4 years, 10 months ago (2016-02-03 02:12:09 UTC) #7
Message was sent while issue was closed.
On 2016/02/02 at 23:54:50, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/6a0471dce5707290e91a67346321bf5ee8969eae
> Cr-Commit-Position: refs/heads/master@{#373080}

The CL that caused the breakage has been reverted:
https://codereview.chromium.org/1666503002

  Thanks!

Powered by Google App Engine
This is Rietveld 408576698