[sql] Framework for allowing tests to handle errors.

sql/sql.gyp

Index: sql/sql.gyp
diff --git a/sql/sql.gyp b/sql/sql.gyp
index 86cfbc9160c71ebb123acbca8aba9453c80d0e43..5b1deb0b5566142b314bf709f7a5c23e0bc82ac8 100644
--- a/sql/sql.gyp
+++ b/sql/sql.gyp
@@ -32,10 +32,27 @@
       'msvs_disabled_warnings': [4267, ],
     },
     {
+      'target_name': 'test_support_sql',
+      'type': 'static_library',
+      'defines': [ 'SQL_IMPLEMENTATION' ],

[erikwright (departed), 2013/06/13 01:26:24]

I think this define should be removed. It is only correct when the target is
being linked into sql.dll (this code is not).

[Scott Hess - ex-Googler, 2013/06/13 03:23:27]

Done.

+      'dependencies': [
+        'sql',
+        '../base/base.gyp:test_support_base',
+        '../testing/gtest.gyp:gtest',
+      ],
+      'export_dependent_settings': [
+        'sql',
+      ],
+      'sources': [
+        'test/scoped_error_ignorer.cc',
+        'test/scoped_error_ignorer.h',
+      ],
+    },
+    {
       'target_name': 'sql_unittests',
       'type': '<(gtest_target_type)',
       'dependencies': [
-        'sql',
+        'test_support_sql',

[erikwright (departed), 2013/06/13 01:26:24]

In the spirit of IWYU I think you should not rely on the transitive dependency
on sql but rather include it explicitly.

[Scott Hess - ex-Googler, 2013/06/13 03:23:27]

Done.

         '../base/base.gyp:test_support_base',
         '../testing/gtest.gyp:gtest',
       ],