[sql] Framework for allowing tests to handle errors.

sql/sql.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 14 matching lines @@
         'meta_table.h',
         'statement.cc',
         'statement.h',
         'transaction.cc',
         'transaction.h',
       ],
       # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
       'msvs_disabled_warnings': [4267, ],
     },
     {
+      'target_name': 'test_support_sql',
+      'type': 'static_library',
+      'defines': [ 'SQL_IMPLEMENTATION' ],

[erikwright (departed), 2013/06/13 01:26:24]

I think this define should be removed. It is only correct when the target is
being linked into sql.dll (this code is not).

[Scott Hess - ex-Googler, 2013/06/13 03:23:27]

Done.

+      'dependencies': [
+        'sql',
+        '../base/base.gyp:test_support_base',
+        '../testing/gtest.gyp:gtest',
+      ],
+      'export_dependent_settings': [
+        'sql',
+      ],
+      'sources': [
+        'test/scoped_error_ignorer.cc',
+        'test/scoped_error_ignorer.h',
+      ],
+    },
+    {
       'target_name': 'sql_unittests',
       'type': '<(gtest_target_type)',
       'dependencies': [
-        'sql',
+        'test_support_sql',

[erikwright (departed), 2013/06/13 01:26:24]

In the spirit of IWYU I think you should not rely on the transitive dependency
on sql but rather include it explicitly.

[Scott Hess - ex-Googler, 2013/06/13 03:23:27]

Done.

         '../base/base.gyp:test_support_base',
         '../testing/gtest.gyp:gtest',
       ],
       'sources': [
         'run_all_unittests.cc',
         'connection_unittest.cc',
         'sqlite_features_unittest.cc',
         'statement_unittest.cc',
         'transaction_unittest.cc',
       ],
@@ skipping 34 matching lines @@
           'variables': {
             'test_suite_name': 'sql_unittests',
             'input_shlib_path': '<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)sql_unittests<(SHARED_LIB_SUFFIX)',
           },
           'includes': [ '../build/apk_test.gypi' ],
         },
       ],
     }],
   ],
 }