Delete old files after an update.

chrome/installer/setup/install_worker.cc

Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 5878c00439e338b422250972c0fa50ccb7bf8aa1..3f5b8d4adc56964fd08bdc813bf559af60f94d2b 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -40,6 +40,7 @@
 #include "chrome/installer/util/callback_work_item.h"
 #include "chrome/installer/util/conditional_work_item_list.h"
 #include "chrome/installer/util/create_reg_key_work_item.h"
+#include "chrome/installer/util/delete_old_versions.h"
 #include "chrome/installer/util/firewall_manager_win.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
@@ -1008,6 +1009,16 @@ bool AppendPostInstallTasks(const InstallerState& installer_state,
     post_install_task_list->AddWorkItem(regular_update_work_items.release());
   }
 
+  // If this is a regular update (chrome.exe not in use), this step will try to
+  // delete files from all versions except the one that was just installed.
+  // Otherwise, it will try to delete files from all versions except the one
+  // that is in use and the one that was just installed.
+  //
+  // TODO(fdoray): Launch a cleanup process if this fails during a regular
+  //               update. crbug.com/451546
+  AddDeleteOldVersionsWorkItem(installer_state, post_install_task_list)
+      ->set_ignore_failure(true);

[grt (UTC plus 2), 2016/02/25 19:25:40]

is it reasonable to do this in the Add function? is there ever a case where a
caller wouldn't want failures to be ignored?

[fdoray, 2016/02/26 17:00:05]

Done. In my previous patch, I didn't to it inside the Add function because I
tested failure in the unit tests. Now I decided to wait until I have the code to
launch the cleanup process to test failure.

+
   AddRegisterComDllWorkItemsForPackage(installer_state, current_version,
                                        new_version, post_install_task_list);