Delete old files after an update.

chrome/installer/setup/install_worker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the definitions of the installer functions that build
 // the WorkItemList used to install the application.
 
 #include "chrome/installer/setup/install_worker.h"
 
 #include <oaidl.h>
@@ skipping 22 matching lines @@
 #include "chrome/installer/setup/app_launcher_installer.h"
 #include "chrome/installer/setup/install.h"
 #include "chrome/installer/setup/setup_constants.h"
 #include "chrome/installer/setup/setup_util.h"
 #include "chrome/installer/setup/update_active_setup_version_work_item.h"
 #include "chrome/installer/util/app_registration_data.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/callback_work_item.h"
 #include "chrome/installer/util/conditional_work_item_list.h"
 #include "chrome/installer/util/create_reg_key_work_item.h"
+#include "chrome/installer/util/delete_old_versions.h"
 #include "chrome/installer/util/firewall_manager_win.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/installation_state.h"
 #include "chrome/installer/util/installer_state.h"
 #include "chrome/installer/util/l10n_string_util.h"
 #include "chrome/installer/util/product.h"
 #include "chrome/installer/util/set_reg_value_work_item.h"
 #include "chrome/installer/util/shell_util.h"
@@ skipping 948 matching lines @@
       regular_update_work_items->AddDeleteRegValueWorkItem(
           root,
           version_key,
           KEY_WOW64_32KEY,
           google_update::kRegRenameCmdField);
     }
 
     post_install_task_list->AddWorkItem(regular_update_work_items.release());
   }
 
+  // If this is a regular update (chrome.exe not in use), this step will try to
+  // delete files from all versions except the one that was just installed.
+  // Otherwise, it will try to delete files from all versions except the one
+  // that is in use and the one that was just installed.
+  //
+  // TODO(fdoray): Launch a cleanup process if this fails during a regular
+  //               update. crbug.com/451546
+  AddDeleteOldVersionsWorkItem(installer_state, post_install_task_list)
+      ->set_ignore_failure(true);

[grt (UTC plus 2), 2016/02/25 19:25:40]

is it reasonable to do this in the Add function? is there ever a case where a
caller wouldn't want failures to be ignored?

[fdoray, 2016/02/26 17:00:05]

Done. In my previous patch, I didn't to it inside the Add function because I
tested failure in the unit tests. Now I decided to wait until I have the code to
launch the cleanup process to test failure.

+
   AddRegisterComDllWorkItemsForPackage(installer_state, current_version,
                                        new_version, post_install_task_list);
 
   // If we're told that we're an MSI install, make sure to set the marker
   // in the client state key so that future updates do the right thing.
   if (installer_state.is_msi()) {
     for (size_t i = 0; i < products.size(); ++i) {
       const Product* product = products[i];
       AddSetMsiMarkerWorkItem(installer_state, product->distribution(), true,
                               post_install_task_list);
@@ skipping 333 matching lines @@
   // Unconditionally remove the legacy Quick Enable command from the binaries.
   // Do this even if multi-install Chrome isn't installed to ensure that it is
   // not left behind in any case.
   work_item_list->AddDeleteRegKeyWorkItem(
                       installer_state.root_key(), cmd_key, KEY_WOW64_32KEY)
       ->set_log_message("removing " + base::UTF16ToASCII(kCmdQuickEnableCf) +
                         " command");
 }
 
 }  // namespace installer