Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1666343002: add kRGBA_F16_SkColorType (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -25 lines) Patch
M include/core/SkColor.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M include/core/SkImageInfo.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M include/core/SkPixmap.h View 1 2 chunks +42 lines, -17 lines 0 comments Download
M src/core/SkColor.cpp View 1 3 chunks +31 lines, -7 lines 0 comments Download
M src/core/SkPixmap.cpp View 1 1 chunk +35 lines, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tests/Float16Test.cpp View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
reed1
4 years, 10 months ago (2016-02-04 21:43:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666343002/1
4 years, 10 months ago (2016-02-04 21:43:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 22:14:31 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666343002/20001
4 years, 10 months ago (2016-02-05 16:35:01 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 16:59:57 UTC) #12
reed1
brian, are you ok if we make a separate CL to upgrade the existing enum ...
4 years, 10 months ago (2016-02-05 19:02:15 UTC) #13
bsalomon
lgtm
4 years, 10 months ago (2016-02-05 19:13:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666343002/20001
4 years, 10 months ago (2016-02-05 19:18:04 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 19:18:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3601f280dc400cb75167393b0a2b6670b5f25ea4

Powered by Google App Engine
This is Rietveld 408576698