Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1666323002: Don't allow oob message interrupts while executing constant expressions in the parser. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't allow oob message interrupts while executing constant expressions in the parser. When this happens we can get complaints about circular dependencies that don't really exist. We were seeing this occasionally on developer_extension_test.dart. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2b74ea304d0898e92dda8a04273e22375b7e75e0

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : address john's dbc #

Patch Set 5 : resolve merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -10 lines) Patch
M runtime/vm/compiler.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 5 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 chunks +68 lines, -10 lines 0 comments Download
M runtime/vm/isolate_test.cc View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
turnidge
4 years, 10 months ago (2016-02-04 21:40:18 UTC) #2
rmacnak
lgtm
4 years, 10 months ago (2016-02-08 20:38:03 UTC) #3
Cutch
https://codereview.chromium.org/1666323002/diff/40001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1666323002/diff/40001/runtime/vm/compiler.cc#newcode1643 runtime/vm/compiler.cc:1643: isolate->DeferMessageInterrupts(); DBC: Consider adding a scope object helper class.
4 years, 10 months ago (2016-02-09 17:05:51 UTC) #5
turnidge
4 years, 10 months ago (2016-02-09 18:04:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
2b74ea304d0898e92dda8a04273e22375b7e75e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698