runtime/vm/compiler.cc - Issue 1666323002: Don't allow oob message interrupts while executing constant expressions in the parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 1666323002: Don't allow oob message interrupts while executing constant expressions in the parser. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: resolve merge conflicts Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index c597499f841b42b3a0685768776549d1e75e8dff..5b67de0488728362a0a9205fa30cd2a2c3a7cb68 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -1466,6 +1466,10 @@ RawObject* Compiler::ExecuteOnce(SequenceNode* fragment) {

LongJumpScope jump;

if (setjmp(*jump.Set()) == 0) {

Thread* const thread = Thread::Current();

+ // Don't allow message interrupts while executing constant

+ // expressions. They can cause bogus recursive compilation.

+ NoOOBMessageScope no_msg_scope(thread);

if (FLAG_trace_compiler) {

THR_Print("compiling expression: ");

if (FLAG_support_ast_printer) {

« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »