Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Issue 1666073002: [turbofan] Remove the function reload hack for OSR. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the function reload hack for OSR. Initially we were unable to address certain stack slots in the callee part of the frame, including the function marker, therefore we had to hack a reload of the function register into the OSR prologue. Now that we are able to address all stack slots, we no longer need this hack. R=jarin@chromium.org Committed: https://crrev.com/359ba8e0dfd5a8a7ea0989264ff1336dbeff247a Cr-Commit-Position: refs/heads/master@{#33974}

Patch Set 1 #

Patch Set 2 : Work-around safe point #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/code-generator.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/linkage.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-04 05:52:14 UTC) #1
Benedikt Meurer
Hey Jaro, Removing an old hack. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-04 05:53:59 UTC) #2
Jarin
lgtm. Thanks!
4 years, 10 months ago (2016-02-04 05:55:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666073002/1
4 years, 10 months ago (2016-02-04 06:09:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/888) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-04 06:31:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666073002/20001
4 years, 10 months ago (2016-02-15 06:58:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 07:30:50 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/359ba8e0dfd5a8a7ea0989264ff1336dbeff247a Cr-Commit-Position: refs/heads/master@{#33974}
4 years, 10 months ago (2016-02-15 07:31:51 UTC) #13
titzer
4 years, 10 months ago (2016-02-15 08:35:33 UTC) #14
Message was sent while issue was closed.
On 2016/02/15 07:31:51, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/359ba8e0dfd5a8a7ea0989264ff1336dbeff247a
> Cr-Commit-Position: refs/heads/master@{#33974}

Nice one, thanks!

Powered by Google App Engine
This is Rietveld 408576698